Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44042: [C++][Parquet] Limit num-of row-groups when build parquet #44043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-44042: [C++][Parquet] Limit num-of row-groups when build parquet #44043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cpp/src/parquet/file_writer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,11 @@ class FileSerializer : public ParquetFileWriter::Contents {
if (row_group_writer_) {
row_group_writer_->Close();
}
if (num_row_groups_ >= std::numeric_limits<int16_t>::max()) {
// Parquet thrifts using int16 for row group ordinal, so we can't have more than
// 32767 row groups in a file.
throw ParquetException("Too many row groups in the file when writing row group");
}
num_row_groups_++;
auto rg_metadata = metadata_->AppendRowGroup();
if (page_index_builder_) {
Expand Down
Loading