Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44096: [C++] Don't use Boost.Process with Emscripten #44097

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

kou
Copy link
Member

@kou kou commented Sep 13, 2024

Rationale for this change

Boost.Process doesn't work with Emscripten. So we can't build arrow::util::Process.

What changes are included in this PR?

Don't use Boost.Process with Emscripten. arrow::util::Process returns Status::NotImplemented with Emscripten.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Because Boost.Process doesn't work with Emscripten.
@kou
Copy link
Member Author

kou commented Sep 13, 2024

@github-actions crossbow submit *-emscripten

Copy link

⚠️ GitHub issue #44096 has been automatically assigned in GitHub to PR creator.

Copy link

Revision: ad112ad

Submitted crossbow builds: ursacomputing/crossbow @ actions-0be59ac65c

Task Status
test-conda-python-emscripten GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions

@kou
Copy link
Member Author

kou commented Sep 13, 2024

+1

This test-conda-python-emscripten failure is unrelated:

https://github.com/ursacomputing/crossbow/actions/runs/10842738518/job/30088799844#step:7:8843

==================================== ERRORS ====================================
____________ ERROR at setup of test_column_chunk_key_value_metadata ____________

    @pytest.fixture(scope='module')
    def parquet_test_datadir():
        result = os.environ.get('PARQUET_TEST_DATA')
        if not result:
>           raise RuntimeError('Please point the PARQUET_TEST_DATA environment '
                               'variable to the test data directory')
E           RuntimeError: Please point the PARQUET_TEST_DATA environment variable to the test data directory

/lib/python3.12/site-packages/pyarrow/tests/parquet/conftest.py:35: RuntimeError

@kou kou merged commit 62060ab into apache:main Sep 13, 2024
39 checks passed
@kou kou deleted the cpp-emscripten-process branch September 13, 2024 22:45
@kou kou removed the awaiting committer review Awaiting committer review label Sep 13, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62060ab.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant