GH-43267: [C#] Correctly import sliced arrays through the C Data interface #44117
Conversation
github-actions
bot
added
awaiting committer review
|
@adamreeve, I would appreciate a quick look at these changes. |
| @@ -7,18 +7,16 @@ | |||
| <Description>Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware.</Description> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(IsWindows)'=='true'"> | |||
| <PropertyGroup> | |||
There was a problem hiding this comment.
Just checking this was intentionally included in the PR? Seems reasonable to now build for net462 on non-Windows too, this built fine for me on Linux and I guess something made sure the reference assemblies / targeting pack was available.
There was a problem hiding this comment.
It was intentional, though arguably I should have put it into a separate PR. What I didn't realize when adding net462 support back was that the official NuGet packages aren't built on Windows and so they were missing the 4.6.2 assembly.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9ba789d. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 97 possible false positives for unstable benchmarks that are known to sometimes produce them. |
What changes are included in this PR?
Changes to the C Data importer to correctly handle nonzero offsets.
Are these changes tested?
Yes
Are there any user-facing changes?
No
Closes #43267