GH-43519: [Python][CI] Update Python 3.13 rc to final 3.13.0 #44375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
@github-actions crossbow submit -g wheels |
|
|
@github-actions crossbow submit -g wheel |
|
Revision: 4fcbcb2 Submitted crossbow builds: ursacomputing/crossbow @ actions-605824d979
|
raulcd
reviewed
Oct 11, 2024
| @@ -84,7 +84,7 @@ RUN (if "%python%"=="3.9" setx PYTHON_VERSION "3.9.13" && setx PATH "%PATH%;C:\P | |||
| (if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11" && setx PATH "%PATH%;C:\Python310;C:\Python310\Scripts") & \ | |||
| (if "%python%"=="3.11" setx PYTHON_VERSION "3.11.9" && setx PATH "%PATH%;C:\Python311;C:\Python311\Scripts") & \ | |||
| (if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5" && setx PATH "%PATH%;C:\Python312;C:\Python312\Scripts") & \ | |||
| (if "%python%"=="3.13" setx PYTHON_VERSION "3.13.0-rc1" && setx PATH "%PATH%;C:\Python313;C:\Python313\Scripts") | |||
| (if "%python%"=="3.13" setx PYTHON_VERSION "3.13.0" && setx PATH "%PATH%;C:\Python313;C:\Python313\Scripts") | |||
There was a problem hiding this comment.
3.13.0 is still not on chocolatey, see: https://community.chocolatey.org/packages/python313
That's why it fails
| @@ -84,7 +84,7 @@ RUN (if "%python%"=="3.9" setx PYTHON_VERSION "3.9.13" && setx PATH "%PATH%;C:\P | |||
| (if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11" && setx PATH "%PATH%;C:\Python310;C:\Python310\Scripts") & \ | |||
| (if "%python%"=="3.11" setx PYTHON_VERSION "3.11.9" && setx PATH "%PATH%;C:\Python311;C:\Python311\Scripts") & \ | |||
| (if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5" && setx PATH "%PATH%;C:\Python312;C:\Python312\Scripts") & \ | |||
There was a problem hiding this comment.
Not strictly required but we can update to the latest on chocolatey.
Suggested change
| (if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5" && setx PATH "%PATH%;C:\Python312;C:\Python312\Scripts") & \ | |
| (if "%python%"=="3.12" setx PYTHON_VERSION "3.12.6" && setx PATH "%PATH%;C:\Python312;C:\Python312\Scripts") & \ |
| @@ -54,7 +54,7 @@ RUN (if "%python%"=="3.9" setx PYTHON_VERSION "3.9.13") & \ | |||
| (if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11") & \ | |||
| (if "%python%"=="3.11" setx PYTHON_VERSION "3.11.9") & \ | |||
| (if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5") & \ | |||
There was a problem hiding this comment.
Not strictly required but we can update to the latest on chocolatey.
Suggested change
| (if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5") & \ | |
| (if "%python%"=="3.12" setx PYTHON_VERSION "3.12.6") & \ |
| @@ -47,17 +47,11 @@ full_version=${versions[$2]} | |||
| if [ $platform = "macOS" ]; then | |||
| echo "Downloading Python installer..." | |||
|
|
|||
| if [ "$version" = "3.13" ] || [ "$version" = "3.13t" ]; | |||
| if [ "$(uname -m)" = "x86_64" ] && [ "$version" = "3.9" ]; | |||
There was a problem hiding this comment.
LGTM, can you also update https://github.com/apache/arrow/pull/44375/files#diff-404e24b955d9320a7b3db90149855e38c86133f626f8b555002212293e79ad80L31 to:
[3.12]=3.12.7
This is the latest with packages (.pkg) on https://www.python.org/ftp/python/
github-actions
bot
added
awaiting changes
|
I'll note that at some point we can probably remove the chocolatey complications (including the uninstall step) on Windows and instead download a distribution from https://github.com/indygreg/python-build-standalone . |
|
@jorisvandenbossche Are you willing to update this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The final Python 3.13.0 is out now, so we can update those versions