Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44444: [Java][CI] Add Java implementation of Flight do_exchange integration test #44445

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Oct 16, 2024

Rationale for this change

See #44444, this helps ensure compatibility of the Java do_exchange implementation with C++ and C#.

What changes are included in this PR?

Adds a Java implementation of the do_exchange:echo Flight integration test, and enables it in Archery.

Are these changes tested?

Yes

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #44444 has been automatically assigned in GitHub to PR creator.

@adamreeve adamreeve force-pushed the do-exchange-java-integration branch from e6617ac to 2fd5e3c Compare October 16, 2024 23:22
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit 1a323fc into apache:main Oct 17, 2024
16 checks passed
@lidavidm lidavidm removed the awaiting review Awaiting review label Oct 17, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 17, 2024
@adamreeve adamreeve deleted the do-exchange-java-integration branch October 17, 2024 08:22
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1a323fc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants