-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44421: [Python] Add configuration for building & testing free-threaded wheels on Windows #44804
base: main
Are you sure you want to change the base?
GH-44421: [Python] Add configuration for building & testing free-threaded wheels on Windows #44804
Conversation
|
If someone could trigger the new jobs, that'd be really helpful! |
@github-actions crossbow submit -g wheel-windows-* |
|
@github-actions crossbow submit wheel-windows-* |
Revision: 78d8f9e Submitted crossbow builds: ursacomputing/crossbow @ actions-86ba33e477 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I triggered the CI jobs
Unfortunately, while the free-threaded wheel is built correctly, |
Also, the failure on 3.9 is that |
I haven't tested and I am unsure if this works but maybe we can try this (https://stackoverflow.com/a/21912169): |
The Windows failure is probably related to pypa/setuptools#4662 and should be fixed in the next setuptools release. |
Hmm, that one should be fixed in CPython AFAIU: python/cpython#111650 |
Ah, scratch that, the rationale is actually here: |
Well, stderr should already be shown by default, so it's weird that nothing gets displayed. |
95a0a53
to
83a76e3
Compare
@github-actions crossbow submit wheel-windows-* |
Given setuptools does not seem in a hurry to merge the distutils fix, I've tried to push a manual workaround in this PR. |
Revision: 83a76e3 Submitted crossbow builds: ursacomputing/crossbow @ actions-5bfc22ac30 |
Well, building the free-threaded wheel failed with:
Edit: I've checked: that file exists in a Python 3.13 Windows install. |
@github-actions crossbow submit wheel-windows-cp313* |
0d30b99
to
55e4cc0
Compare
@github-actions crossbow submit wheel-windows-cp313* |
Revision: 55e4cc0 Submitted crossbow builds: ursacomputing/crossbow @ actions-1076ab812c
|
@github-actions crossbow submit wheel-windows-cp313* |
This comment was marked as outdated.
This comment was marked as outdated.
e4c9baf
to
184510c
Compare
@github-actions crossbow submit wheel-windows-cp313* |
This comment was marked as outdated.
This comment was marked as outdated.
184510c
to
b5fbae1
Compare
@github-actions crossbow submit wheel-windows-cp313* |
This comment was marked as outdated.
This comment was marked as outdated.
b5fbae1
to
771cf66
Compare
@github-actions crossbow submit wheel-windows-cp313* |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit wheel-windows-cp313* |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit wheel-windows-cp313* |
Revision: da27ca9 Submitted crossbow builds: ursacomputing/crossbow @ actions-4bc1383e5a
|
@github-actions crossbow submit wheel-windows-cp313* |
Revision: de2f14a Submitted crossbow builds: ursacomputing/crossbow @ actions-bfacfef460
|
Rationale for this change
There's no blockers anymore for building Windows wheels for the free-threaded build, so this PR adds the necessary configuration to do that.
What changes are included in this PR?
Are these changes tested?
No tests required.
Are there any user-facing changes?
No.