Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44878: [Archery] Only suppress Docker progress logs when running on CI #44865

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Nov 27, 2024

Rationale for this change

#44669 went overboard by always suppressing Docker progress output. This may be desirable on CI, to avoid flooding the logs, but is annoying when running archery docker locally.

What changes are included in this PR?

Only suppress Docker progress output if on CI.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes, this restores the previous behavior for non-CI runs.

@pitrou
Copy link
Member Author

pitrou commented Nov 27, 2024

Also cc @kszucs

@kou kou changed the title GH-44667: [Archery] Only suppress Docker progress logs when running on CI GH-44878: [Archery] Only suppress Docker progress logs when running on CI Nov 28, 2024
Copy link

⚠️ GitHub issue #44878 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

dev/archery/archery/docker/tests/test_docker.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Nov 28, 2024
@pitrou pitrou force-pushed the gh44667-docker-ci-quiet branch from f4fb2cf to 4db6b78 Compare November 28, 2024 09:31
@pitrou
Copy link
Member Author

pitrou commented Nov 28, 2024

@github-actions crossbow submit test-conda-cpp

Copy link

Revision: 4db6b78

Submitted crossbow builds: ursacomputing/crossbow @ actions-5512f7e45a

Task Status
test-conda-cpp GitHub Actions

@pitrou pitrou merged commit 70343d3 into apache:main Nov 28, 2024
7 checks passed
@pitrou pitrou removed the awaiting merge Awaiting merge label Nov 28, 2024
@pitrou pitrou deleted the gh44667-docker-ci-quiet branch November 28, 2024 09:54
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 70343d3.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants