-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44878: [Archery] Only suppress Docker progress logs when running on CI #44865
Conversation
ed37e06
to
9e33adf
Compare
Also cc @kszucs |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
f4fb2cf
to
4db6b78
Compare
@github-actions crossbow submit test-conda-cpp |
Revision: 4db6b78 Submitted crossbow builds: ursacomputing/crossbow @ actions-5512f7e45a
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 70343d3. There were 132 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
#44669 went overboard by always suppressing Docker progress output. This may be desirable on CI, to avoid flooding the logs, but is annoying when running
archery docker
locally.What changes are included in this PR?
Only suppress Docker progress output if on CI.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes, this restores the previous behavior for non-CI runs.