Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [R] Verify CRAN release-18.1.0-rc2 #44914

Closed
wants to merge 5 commits into from
Closed

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Dec 3, 2024

Caution

Do not merge this PR.

This PR is being used to prepare for the CRAN submission for 18.1.0.

See packaging checklist: #44913.

@amoeba
Copy link
Member Author

amoeba commented Dec 3, 2024

@github-actions crossbow submit --group r

Copy link

github-actions bot commented Dec 3, 2024

Revision: 6a7803a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1ea05cf73c

Task Status
r-binary-packages GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-clang-sanitizer GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-opensuse155 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions
test-ubuntu-r-sanitizer GitHub Actions

@amoeba
Copy link
Member Author

amoeba commented Dec 3, 2024

@github-actions crossbow submit r-recheck-most

Copy link

github-actions bot commented Dec 3, 2024

Unable to match any tasks for `r-recheck-most`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/12133246989

We skipped 18.0.0 and did our first 18.X CRAN release with 18.1.0 so we shouldn't have an 18.0.0 header.
…ies on GHA (#43784)

### Rationale for this change

See #43547.

### What changes are included in this PR?

Adds two new new crossbow tasks for performing reverse dependency checking using https://github.com/r-devel/recheck: 

- `r-recheck-most` 
- `r-recheck-strong`

### Are these changes tested?

Yes. #44523 (comment).

### Are there any user-facing changes?

No.
* GitHub Issue: #43547

Fixes #43547.

Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
@amoeba
Copy link
Member Author

amoeba commented Dec 3, 2024

@github-actions crossbow submit r-recheck-most

Copy link

github-actions bot commented Dec 3, 2024

Revision: 575cbdd

Submitted crossbow builds: ursacomputing/crossbow @ actions-dcd649ba74

Task Status
r-recheck-most GitHub Actions

@jonkeane
Copy link
Member

jonkeane commented Dec 4, 2024

The devdocs build always seems to fail on these branches but that's ok. I suspect (but haven't dug to the bottom to confirm this) is that we are installing from apt the release version and we are installing the same version so our use-the-dev-version code isn't catching like it does in all other circumstances. (it failed for #44523 as well, but it is passing in the nightlies)

The failure of test-r-rhub-debian-gcc-devel-lto-latest is a bit more concerning. It looks like that's been failing for 12 days now. I don't see anything obvious in our repo just after 27bbd59...0cdbdac but I also don't see any changes in the image that these run on either: https://github.com/r-hub/containers/commits/main/ But those tests don't run on CRAN, so we should be ok to submit, though we should make an issue and figure out what's up there.

The recheck job looks red, but I think it's ok looking at the output? Am I reading that correctly?

@amoeba
Copy link
Member Author

amoeba commented Dec 4, 2024

Thanks for taking a look @jonkeane.

  1. Re: devocs-ubuntu: Ah, yep. I should've checked previous runs. Good thing to note.
  2. Re: test-r-rhub-debian-gcc-devel-lto-latest, I'll file an issue for that in a bit.
  3. Re: r-recheck: I agree that this is just noise and that we're good in terms of revdep checks.

@amoeba
Copy link
Member Author

amoeba commented Dec 18, 2024

Closing as we're done testing and 18.1.0 is on CRAN.

@amoeba amoeba closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants