Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Format] Schema.fbs typo -- s/maybe/may be/ #45023

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

akesling
Copy link
Contributor

Rationale for this change

To improve a comment.

What changes are included in this PR?

Correction of a mispelling in a comment: s/maybe/may be/.

Are these changes tested?

N/A

Are there any user-facing changes?

No

@github-actions github-actions bot added the awaiting review Awaiting review label Dec 13, 2024
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the typo.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 16, 2024
@zanmato1984
Copy link
Contributor

zanmato1984 commented Dec 16, 2024

Hi @akesling , I see you have 5 PRs (#45022 , this one, #45024 , #45025 , #45026 ) fixing single typo in Schema.fbs. All of them are good, and thank you for that. But could you combine them into a single PR (say, this one, because it is the first one catching my eyes), to keep our commit history cleaner? Thanks.

@raulcd
Copy link
Member

raulcd commented Dec 16, 2024

I agree with @zanmato1984 , those PRs could be combined on a single PR fixing various typos.

@kou kou changed the title MINOR: Schema.fbs typo -- s/maybe/may be/ MINOR: [Format] Schema.fbs typo -- s/maybe/may be/ Dec 18, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I'm OK with small PRs. They are easy to review and we can merge quickly.

@kou kou merged commit 21feb16 into apache:main Dec 18, 2024
7 of 8 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Dec 18, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants