Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45034: [C++] Remove Parquet requirement from Arrow Acero and from Arrow Dataset when not necessary #45035

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Dec 16, 2024

Rationale for this change

Currently we are defining Parquet as a requirement for Acero and for Dataset on ArrowAceroConfig.cmake.in and ArrowDatasetConfig.cmake.in respectively.

Parquet should never be necessary for Acero and could be necessary for Dataset only if it has been built with Parquet support.

What changes are included in this PR?

Remove Parquet from ArrowAceroConfig.cmake.in and add it as optional dependency for ArrowDatasetConfig.cmake.in

Are these changes tested?

I've tested with a really minimal build of Arrow and Pyarrow. I don't think we want to add a build without Parquet but with Dataset and/or Acero at CI just to test this scenario.
Logs for the local build without Parquet:

-- Found Cython version: 3.0.11
-- Arrow version: 19.0.0
-- Found the Arrow shared library: /home/raulcd/code/dist/lib/libarrow.so.1900.0.0
-- Found the Arrow import library: ARROW_IMPORT_LIB-NOTFOUND
-- Found the Arrow static library: 
-- Building PyArrow with Dataset
-- ArrowAcero version: 19.0.0
-- Found the ArrowAcero shared library: /home/raulcd/code/dist/lib/libarrow_acero.so.1900.0.0
-- Found the ArrowAcero import library: ARROW_ACERO_IMPORT_LIB-NOTFOUND
-- Found the ArrowAcero static library: 
-- ArrowDataset version: 19.0.0
-- Found the ArrowDataset shared library: /home/raulcd/code/dist/lib/libarrow_dataset.so.1900.0.0
-- Found the ArrowDataset import library: ARROW_DATASET_IMPORT_LIB-NOTFOUND
-- Found the ArrowDataset static library: 
-- Building PyArrow with Acero
-- Parquet Encryption is NOT Enabled

The IMPORT_LIB-NOTFOUND has always been present and it's not new.

Are there any user-facing changes?

No as this should have already been the case.

Copy link

⚠️ GitHub issue #45034 has been automatically assigned in GitHub to PR creator.

@raulcd raulcd marked this pull request as ready for review December 16, 2024 19:54
@raulcd raulcd requested a review from westonpace as a code owner December 16, 2024 19:54
@raulcd raulcd requested review from kou and assignUser December 16, 2024 19:54
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Dec 17, 2024
@kou kou merged commit 2cc30eb into apache:main Dec 17, 2024
39 checks passed
@kou kou removed the awaiting merge Awaiting merge label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants