Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS #45046

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Dec 17, 2024

Rationale for this change

We are currently downloading and building ORC every time for our wheels. We should not require to bundle ORC ourselves and we could just use vcpkg.

What changes are included in this PR?

Stop using ORC_SOURCE=BUNDLED and enable the vcpkg orc feature.

Are these changes tested?

Yes, on the wheels.

Are there any user-facing changes?

No

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 17, 2024
@raulcd
Copy link
Member Author

raulcd commented Dec 17, 2024

@github-actions crossbow submit wheel-manylinux-2-28-cp312-cp312-amd64

Copy link

Revision: 6eb5042

Submitted crossbow builds: ursacomputing/crossbow @ actions-b309acbcb8

Task Status
wheel-manylinux-2-28-cp312-cp312-amd64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Dec 17, 2024

We can see on the new logs, and is not downloaded/built anymore:

 -- Found orcAlt: /opt/vcpkg/installed/amd64-linux-static-release/lib/liborc.a (found version "2.0.0")
-- Providing CMake module for FindorcAlt as part of Arrow CMake package
-- Found ORC static library: /opt/vcpkg/installed/amd64-linux-static-release/lib/liborc.a
-- Found ORC headers: /opt/vcpkg/installed/amd64-linux-static-release/include

the orc tests on pyarrow being successful:

usr/local/lib/python3.12/site-packages/pyarrow/tests/test_orc.py ....... [ 86%]
......                                                                   [ 87%]

Previously it was built and we could see both the build process and the following log:

 -- Building Apache ORC from source

@raulcd
Copy link
Member Author

raulcd commented Dec 17, 2024

@github-actions crossbow submit wheel-manylinux-*

Copy link

Revision: 6eb5042

Submitted crossbow builds: ursacomputing/crossbow @ actions-a95168b3c6

Task Status
wheel-manylinux-2-28-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-arm64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Dec 17, 2024

@github-actions crossbow submit wheel-macos-*

Copy link

Revision: 6eb5042

Submitted crossbow builds: ursacomputing/crossbow @ actions-ad62b7a323

Task Status
wheel-macos-monterey-cp310-cp310-amd64 GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64 GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64 GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64 GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64 GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64 GitHub Actions
wheel-macos-monterey-cp39-cp39-amd64 GitHub Actions
wheel-macos-monterey-cp39-cp39-arm64 GitHub Actions

@raulcd raulcd marked this pull request as ready for review December 17, 2024 16:50
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Dec 17, 2024
@kou kou merged commit 6c9e7e7 into apache:main Dec 17, 2024
36 checks passed
@kou kou removed the awaiting merge Awaiting merge label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants