GH-45075: [C++] Remove result_internal.h #45066
Merged
+33
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
|
This is perhaps not minor (can you open an issue?), but otherwise LGTM. |
wgtmac
changed the title
|
|
Created an issue and changed the PR title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The result_internal.h file contains only the definition of
ASSIGN_OR_RAISEand thus can be removed becauseARROW_ASSIGN_OR_RAISEis preferred overASSIGN_OR_RAISE.What changes are included in this PR?
Remove result_internal.h and use
ARROW_ASSIGN_OR_RAISEto replaceASSIGN_OR_RAISE.Are these changes tested?
Pass CI.
Are there any user-facing changes?
No.