GH-45069: [R][CI] Fix r-binary-packages crossbow job #45070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit r-binary-packages |
|
Revision: e981773 Submitted crossbow builds: ursacomputing/crossbow @ actions-1cc2039c38
|
amoeba
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
I think my hunch was right, @assignUser can you take a look whenever you have a chance? |
|
This isn't quite ready to be merged. The final step fails to find Rscript so I'll see how we can get that installed too. Edit: Turns out I just missed a change. |
|
@github-actions crossbow submit r-binary-packages |
|
Revision: 5d38904 Submitted crossbow builds: ursacomputing/crossbow @ actions-0119c2fc88
|
|
This looks good now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GitHub phased out R from their Ubuntu images in their 24.04 image and this job started failing because of it. We now need to install R ourselves if a job needs it and uses ubuntu-latest (>=24.04).
What changes are included in this PR?
Change in GHA workflow config to always install R.
Are these changes tested?
They're testing here with crossbow.
Are there any user-facing changes?
No.