-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45132: [C++][Gandiva] Revert LVVM JIT upgrade #45114
base: main
Are you sure you want to change the base?
Conversation
|
|
Could you open a new issue for this? |
|
|
|
We have arrow/cpp/src/gandiva/engine.cc Lines 159 to 177 in f5c340b
Can we register |
Rationale for this change
#37848 upgraded the JIT compiler for LLVM/Gandiva code which presented linking errors with newer version of LLVM. Some Gandiva tests were disabled, and here at Dremio I am running into the same linking problem when trying to build with an updated Arrow library. LLVM devs are aware of the linking problem, which seems to be an issue with the package exports, but there is no fix yet. In the meantime I'm proposing reverting the JIT upgrade since it was a maintenance item and not strictly necessary at this time.
More discussion in apache/arrow-java#63.
What changes are included in this PR?
Reverting #37848
Are these changes tested?
Covered by existing tests.
Are there any user-facing changes?
No.