Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use C++17 with GCC15 for now #45150

Closed
wants to merge 6 commits into from
Closed

[WIP] Use C++17 with GCC15 for now #45150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31f3cce
used C++17 with GCC15 for now
jonkeane Jan 1, 2025
7e63bd1
turn off tests temporarily
jonkeane Jan 1, 2025
b9cd037
does xxhash resolve withotu ccache?
jonkeane Jan 1, 2025
2f9b2d2
add libxxhash
jonkeane Jan 1, 2025
891b839
no gandiva
jonkeane Jan 1, 2025
59a5dc0
PR comments
jonkeane Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/docker/debian-experimental-cpp.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ RUN if [ -n "${gcc}" ]; then \
libutf8proc-dev \
libxml2-dev \
libxsimd-dev \
libxxhash-dev \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this I had linker errors with xxhash. Though I'm surprised this isn't needed for debian 12?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sid/experimental's liblz4.so uses libxxhash.so.

libzstd-dev \
make \
ninja-build \
Expand Down Expand Up @@ -111,7 +112,7 @@ RUN /arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
# Prioritize system packages and local installation.
ENV ARROW_ACERO=ON \
ARROW_AZURE=ON \
ARROW_BUILD_TESTS=ON \
ARROW_BUILD_TESTS=OFF \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this, but since we don't build tests on CRAN I'm checking to see if this being off gets us to a successful build.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try BUILD_WARNING_LEVEL=PRODUCTION instead?
It doesn't add -Werror.

ARROW_DATASET=ON \
ARROW_DEPENDENCY_SOURCE=SYSTEM \
ARROW_DATASET=ON \
Expand Down
3 changes: 2 additions & 1 deletion dev/tasks/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,8 @@ tasks:
ARCH: "amd64"
DEBIAN: "experimental"
GCC: "15"
flags: "-e CMAKE_CXX_STANDARD=20"
LLVM: "19"
flags: "-e CMAKE_CXX_STANDARD=17"
image: debian-cpp

test-fedora-39-cpp:
Expand Down
Loading