GH-45212: [C++][Parquet] Fix uninitialized size_statistics_level property #45213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l property The PR to introduce SizeStatistics has spanned several months, during which time WriterProperties::Builder(const WriterProperties& properties) was added. This commit fixes that function to initialize size_statistics_level_.
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
|
@github-actions crossbow submit -g cpp |
|
Revision: 130db76 Submitted crossbow builds: ursacomputing/crossbow @ actions-3485d333b1
|
pitrou
approved these changes
Jan 9, 2025
github-actions
bot
added
awaiting committer review
mapleFU
approved these changes
Jan 9, 2025
|
Yes, I think this is a good candidate for 19.0.0 inclusion @amoeba |
amoeba
pushed a commit
that referenced
this pull request
Jan 9, 2025
…erty (#45213) ### Rationale for this change The PR to introduce SizeStatistics has spanned several months, during which time WriterProperties::Builder(const WriterProperties& properties) was added. ### What changes are included in this PR? This PR fixes WriterProperties::Builder(const WriterProperties& properties) function to initialize size_statistics_level_. ### Are these changes tested? Pass CIs. ### Are there any user-facing changes? No. * GitHub Issue: #45212 Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]>
amoeba
pushed a commit
that referenced
this pull request
Jan 11, 2025
…erty (#45213) ### Rationale for this change The PR to introduce SizeStatistics has spanned several months, during which time WriterProperties::Builder(const WriterProperties& properties) was added. ### What changes are included in this PR? This PR fixes WriterProperties::Builder(const WriterProperties& properties) function to initialize size_statistics_level_. ### Are these changes tested? Pass CIs. ### Are there any user-facing changes? No. * GitHub Issue: #45212 Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3695d3d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The PR to introduce SizeStatistics has spanned several months, during which time WriterProperties::Builder(const WriterProperties& properties) was added.
What changes are included in this PR?
This PR fixes WriterProperties::Builder(const WriterProperties& properties) function to initialize size_statistics_level_.
Are these changes tested?
Pass CIs.
Are there any user-facing changes?
No.