Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45257: [C++][Parquet] Fix Statistics<ByteArray> Cleanup handling #45258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jan 14, 2025

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@mapleFU mapleFU requested a review from wgtmac as a code owner January 14, 2025 15:28
Copy link

⚠️ GitHub issue #45257 has been automatically assigned in GitHub to PR creator.

if (min_max.first.len != 0) {
return ::std::nullopt;
}
min_max.first = empty;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will we see this kind of data?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the root cause is here:

if (!encoded_min.empty()) {
PlainDecode(encoded_min, &min_);
}
if (!encoded_max.empty()) {
PlainDecode(encoded_max, &max_);
}
has_min_max_ = has_min_max;

When both min_value and max_value exist but at least one of them is an empty string, min_ or max_ is not initialized.

Should we fix here instead of CleanStatistics above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants