GH-46141: Add flight directory to Meson configuration #46142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
WillAyd
force-pushed
the
meson-flight-directory
branch
2 times, most recently
from
e88300c to
eddb36a
Compare
WillAyd
commented
Apr 14, 2025
| @@ -24,7 +24,7 @@ project( | |||
| meson_version: '>=1.3.0', | |||
| default_options: [ | |||
| 'buildtype=release', | |||
| 'c_std=c99', | |||
| 'c_std=gnu11,c11', | |||
There was a problem hiding this comment.
I bumped this to C11 as that is what the CMake configuration uses, but it also appears that the c-ares dependency requires some POSIX extensions
There was a problem hiding this comment.
Namely it appears that c-ares wants to include macros from <net/if.h> and looks for macros like CLOCK_MONOTONIC from time.h on non-windows platforms
github-actions
bot
added
awaiting committer review
WillAyd
force-pushed
the
meson-flight-directory
branch
from
eddb36a to
97138b8
Compare
|
I am not very familiar with Flight so apologies for any oversights, but I think this is a reasonable translation of the CMakeLists.txt |
|
@github-actions crossbow submit *meson |
|
Revision: 97138b8 Submitted crossbow builds: ursacomputing/crossbow @ actions-9b43f97786
|
WillAyd
force-pushed
the
meson-flight-directory
branch
from
97138b8 to
56cec4d
Compare
WillAyd
force-pushed
the
meson-flight-directory
branch
from
56cec4d to
101f900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Continues building out support for Meson as a build system generator
What changes are included in this PR?
This adds the flight directory to the Meson configuration
Are these changes tested?
Locally
Are there any user-facing changes?
No