-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46231: [C++][CMake] Fix arrow_bundled_dependencies
to be externally accessible by FetchContent
#46232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@github-actions crossbow submit -g cpp -g r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 if CI is green.
FYI: We don't support FetchContent yet...:
Revision: 7d50c4a Submitted crossbow builds: ursacomputing/crossbow @ actions-7cc39ab5b3 |
It seems that I managed to use |
Rationale for this change
arrow_bundled_dependencies
is an IMPORTED library which links toarrow_bundled_dependencies_merge
. When arrow-cpp is used externally as a third-party dependency via CMakeFetchContent
, targetarrow_bundled_dependencies
is not accessible by the parent project (butarrow_bundled_dependencies_merge
is). It is difficult for the parent project to locate the built product ofarrow_bundled_dependencies_merge
and install it.What changes are included in this PR?
Change
IMPORTED
libraryarrow_bundled_dependencies
to beGLOBAL
.Are these changes tested?
Are there any user-facing changes?
I don't think so.