-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47588: [C++] Bump mimalloc version to 3.0.9 #47589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
79182eb
to
f79033d
Compare
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
e27d1e8
to
709942b
Compare
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
@ursabot please benchmark |
Benchmark runs are scheduled for commit 709942b. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit 709942b. There were 80 benchmark results indicating a performance regression:
The full Conbench report has more details. |
According to microsoft/mimalloc#1073 , mimalloc v3 is preferred over v2 for production usage.
709942b
to
57aecbf
Compare
@github-actions crossbow submit -g cpp |
Revision: 57aecbf Submitted crossbow builds: ursacomputing/crossbow @ actions-35dfb14f79 |
Rationale for this change
According to microsoft/mimalloc#1073 , mimalloc v3 is preferred over v2 for production usage.
What changes are included in this PR?
Bump to mimalloc 3.0.9, which is the latest mimalloc v3 release as of this writing.
Are these changes tested?
Yes, by existing tests and CI.
Are there any user-facing changes?
Hopefully not, besides a potential reduction in memory usage due to improvements in mimalloc v3.