GH-40096: [C++][Parquet] Expand ParquetVersion enum values #47618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
Component: Parquet
Component: C++
Component: Python
awaiting committer review
thisisnic
commented
Sep 22, 2025
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
thisisnic
commented
Sep 22, 2025
Comment on lines
+138
to
+140
| PARQUET_1_0 = 0L, PARQUET_2_4 = 1L, PARQUET_2_6 = 2L, | ||
| PARQUET_2_7 = 3L, PARQUET_2_8 = 4L, PARQUET_2_9 = 5L, PARQUET_2_10 = 6L, | ||
| PARQUET_2_11 = 7L, PARQUET_2_12 = 8L |
There was a problem hiding this comment.
Apparently this change ensures it matches up with the C++; not sure about this myself.
There was a problem hiding this comment.
@jonkeane If we export this enum, does that mean we shouldn't go changing previous values, or that it's actually important to sync up with the C++ values? I'm not confident I fully understand how enums are used here and what matches what.
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
thisisnic
commented
Sep 22, 2025
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ParquetVersion enum values weren't up to date with Parquet versions
What changes are included in this PR?
Update ParquetVersion to latest Parquet versions
Are these changes tested?
Yes
Are there any user-facing changes?
Yes - default assumption for Parquet version 2.X is 2.12 not 2.6.