GH-47719: [C++][FlightRPC] Extract SQLTables Implementation #48021
+623
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
reviewed
Oct 31, 2025
| namespace { | ||
| // Helper Functions | ||
|
|
||
| std::wstring GetStringColumnW(SQLHSTMT stmt, int colId) { |
Contributor
There was a problem hiding this comment.
we might consider moving this GetStringColumnW to a more accessible place shared by all tests
Contributor
Author
There was a problem hiding this comment.
Moved to odbc_test_suite.
github-actions
bot
added
awaiting committer review
Co-Authored-By: rscales <[email protected]>
justing-bq
changed the title
|
|
Contributor
Author
|
@lidavidm Could we get a review? Thanks. |
lidavidm
approved these changes
Nov 6, 2025
github-actions
bot
added
awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Addresses #47719
What changes are included in this PR?
SQLTables enabled. Table tests added.
Are these changes tested?
Tests are not expected to pass yet.
Are there any user-facing changes?
No.