-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12017: [R] [Documentation] Make proper developing arrow docs #9898
Conversation
@github-actions crossbow submit test-r-devdocs |
Revision: 39c54e0 Submitted crossbow builds: ursacomputing/crossbow @ actions-255
|
@github-actions crossbow submit test-r-devdocs |
Revision: 9322b2f Submitted crossbow builds: ursacomputing/crossbow @ actions-256
|
@github-actions crossbow submit test-r-devdocs |
Revision: fa38ece Submitted crossbow builds: ursacomputing/crossbow @ actions-257
|
@github-actions crossbow submit test-r-devdocs |
Revision: ef4822b Submitted crossbow builds: ursacomputing/crossbow @ actions-258
|
@github-actions crossbow submit test-r-devdocs |
Revision: e138963 Submitted crossbow builds: ursacomputing/crossbow @ actions-259
|
@github-actions crossbow submit test-r-devdocs |
Revision: 2b3ab66 Submitted crossbow builds: ursacomputing/crossbow @ actions-260
|
r/vignettes/dev-docs.Rmd
Outdated
-DCMAKE_BUILD_TYPE=release \ | ||
-DARROW_WITH_SNAPPY=ON \ | ||
-DARROW_WITH_ZLIB=ON \ | ||
-DARROW_INSTALL_NAME_RPATH=OFF \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is only relevant for macOS, so you could make this conditional (since you're already doing conditional things)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I will do that + the other various conditionals when I start writing the actual docs. I wanted to get it building for now and then edit/add to it knowing that everything I was writing was tested later.
@github-actions crossbow submit test-r-devdocs |
Revision: 4591e85 Submitted crossbow builds: ursacomputing/crossbow @ actions-261
|
@github-actions crossbow submit test-r-devdocs |
Revision: 42439f4 Submitted crossbow builds: ursacomputing/crossbow @ actions-262
|
@github-actions crossbow submit test-r-devdocs |
Revision: edf1b56 Submitted crossbow builds: ursacomputing/crossbow @ actions-263
|
@github-actions crossbow submit test-r-devdocs |
Revision: 0723761 Submitted crossbow builds: ursacomputing/crossbow @ actions-272
|
@github-actions crossbow submit test-r-devdocs |
Revision: 6f7bba0 Submitted crossbow builds: ursacomputing/crossbow @ actions-273
|
@github-actions crossbow submit test-r-devdocs |
f7a624f
to
f7558d6
Compare
Revision: f7558d6 Submitted crossbow builds: ursacomputing/crossbow @ actions-279
|
@github-actions crossbow submit test-r-devdocs |
Revision: e3c5185 Submitted crossbow builds: ursacomputing/crossbow @ actions-282
|
Co-authored-by: Neal Richardson <[email protected]>
e043a92
to
0bd6db9
Compare
Closes apache#9898 from jonkeane/ARROW-12017-dev-docs Lead-authored-by: Jonathan Keane <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Neal Richardson <[email protected]>
Closes apache#9898 from jonkeane/ARROW-12017-dev-docs Lead-authored-by: Jonathan Keane <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Neal Richardson <[email protected]>
Closes apache#9898 from jonkeane/ARROW-12017-dev-docs Lead-authored-by: Jonathan Keane <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Neal Richardson <[email protected]>
No description provided.