Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3871: Support nested lists/maps in BlockingDirectBinaryEncoder #2732

Merged
merged 4 commits into from
May 5, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 12, 2024

What is the purpose of the change

(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Extended interop tests to verify consistent valid schema names between SDKs
  • Added test that validates that Java throws an AvroRuntimeException on invalid binary data
  • Manually verified the change by building the website and checking the new redirect

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the Java Pull Requests for Java binding label Feb 12, 2024
@Fokko Fokko changed the title Support nested lists/maps in BlockingDirectBinaryEncoder AVRO-3871: Support nested lists/maps in BlockingDirectBinaryEncoder Feb 12, 2024
@Fokko Fokko force-pushed the fd-support-nested-maps-arrays branch 2 times, most recently from 12d44d1 to c1be917 Compare February 12, 2024 15:05
@Fokko Fokko force-pushed the fd-support-nested-maps-arrays branch from c1be917 to 1b08260 Compare February 12, 2024 15:10
@Fokko Fokko merged commit 9f9023c into apache:main May 5, 2024
8 checks passed
@Fokko
Copy link
Contributor Author

Fokko commented May 5, 2024

Thanks @jbonofre 🙌

@Fokko Fokko deleted the fd-support-nested-maps-arrays branch May 5, 2024 20:48
Fokko added a commit to Fokko/avro that referenced this pull request May 5, 2024
Fokko added a commit to Fokko/avro that referenced this pull request May 7, 2024
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
Fokko added a commit that referenced this pull request Jun 11, 2024
* AVRO-3983: Allow setting a custom encoder in DataFileWriter (#2874)

* AVRO-3871: Add blocking direct binary encoder (#2521)

* Java: Add blocking direct binary encoder

* Optimize

* Comments and more tests

* Comments and more tests

* Fix rat check

* AVRO-3871: Support nested lists/maps in BlockingDirectBinaryEncoder (#2732)

* Support nested lists/maps

* Add some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Pull Requests for Java binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants