PubsubMessageWithTopicCoder.of() is returning wrong coder

[stankiewicz]

PubsubMessageWithTopicCoder should return PubsubMessageWithTopicCoder PubsubMessageWithAttributesAndMessageIdCoder.

While investigating Dynamic Destinations on Direct runner I found out that PubsubMessageWithTopicCoder is never used and topic is lost and pipeline fails.

fixes #31679

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @chamikaramj for label io.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[sjvanrossum]

@stankiewicz do you mind also cleaning up the one occurrence of new PubsubMessageWithTopicCoder() here to use PubsubMessageWithTopicCoder.of() instead?

[m-trieu]

lgtm java

[chamikaramj]

Ah, wow. Thanks for the fix.

Out of curiosity, did you actually run into a failure due to this ?
Also, would you mind filing a Github issue with details and the actual failure you potentially ran into ?

[stankiewicz]

Yes. It took a while to debug the issue:)
bug is created.

[chamikaramj]

Thanks LGTM.

Seems like this was added in https://github.com/apache/beam/pull/26063/files

cc: @reuvenlax in case we are missing something here.

[stankiewicz]

Shall we merge it?

[github-actions]

Reminder, please take a look at this pr: @m-trieu @chamikaramj

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @ahmedabu98 for label io.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)