Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postcommit python arm workflow #33799

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

akashorabek
Copy link
Collaborator

@akashorabek akashorabek commented Jan 29, 2025

#30760
For now, disabled the tests for python 3.9 and 3.10 in sklearn_inference_it_test.py due to an incompatibility with the new NumPy versions. This issue caused the following error: ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject. Created the issue to investigate possible workarounds.
Example of a job without the ValueError - https://github.com/akashorabek/beam/actions/runs/13031140520. (The failure in Python 3.12 is unrelated and is caused by an existing issue with the build_wheels task)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.49%. Comparing base (3d651eb) to head (d4c0417).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #33799   +/-   ##
=========================================
  Coverage     59.48%   59.49%           
  Complexity     4683     4683           
=========================================
  Files          1348     1348           
  Lines        184681   184721   +40     
  Branches       4455     4455           
=========================================
+ Hits         109852   109891   +39     
- Misses        71088    71089    +1     
  Partials       3741     3741           
Flag Coverage Δ
python 81.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@akashorabek
Copy link
Collaborator Author

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jrmccluskey jrmccluskey merged commit 3c563e8 into apache:master Jan 29, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants