Avoid double loading in Cassandra side of journal #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifesdjeen
force-pushed
the
CASSANDRA-20244
branch
from
a62da52 to
e64f5b8
Compare
| @@ -414,6 +415,8 @@ private static Command.Truncated truncated(TxnId txnId, SaveStatus status, Statu | |||
| case TruncatedApplyWithOutcome: | |||
| case TruncatedApplyWithDeps: | |||
| case TruncatedApply: | |||
| if (status != TruncatedApplyWithOutcome) | |||
There was a problem hiding this comment.
Can we add a TODO to tidy this up when we have a better solution?
There was a problem hiding this comment.
Would be good to mention the reason this arises. Unfortunately I've forgotten since we spoke, I think it may be because of compaction? Because if we write out a truncate record to the log it should null out this field.
There was a problem hiding this comment.
Reverted for now; I'm sure it'll show up in burn test. When it does, we will document and/or fix it, wdyt?
ifesdjeen
force-pushed
the
CASSANDRA-20244
branch
4 times, most recently
from
de13f4a to
6a52dbb
Compare
ifesdjeen
force-pushed
the
CASSANDRA-20244
branch
3 times, most recently
from
f6ac18b to
707b37c
Compare
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
183d5d0 to
cd7f495
Compare
ifesdjeen
force-pushed
the
CASSANDRA-20244
branch
5 times, most recently
from
27e7598 to
4da7aa7
Compare
belliottsmith
approved these changes
Feb 4, 2025
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20244
…built command from journal
ifesdjeen
force-pushed
the
CASSANDRA-20244
branch
from
122838f to
18dac1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.