Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18255 #95

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

18255 #95

wants to merge 2 commits into from

Conversation

ekaterinadimitrova2
Copy link
Contributor

No description provided.

@michaelsembwever
Copy link
Member

michaelsembwever commented Jul 20, 2023

The Fix JDK setup commit isn't needed.

Only older branches use jdk8 and only older branches don't have java.supported.
The commit only helps a run that doesn't exist to fail a little faster. These scripts won't be used for trunk soon (CASSANDRA-18665). The change is temporary and involves work and risk – I'd just not include that commit

@michaelsembwever
Copy link
Member

+1 on the first commit.

@ekaterinadimitrova2
Copy link
Contributor Author

@michaelsembwever Where does it fail then?
If I do not add that check for 8, we will also build with JDK8 for trunk. What do I miss?

@michaelsembwever
Copy link
Member

michaelsembwever commented Jul 20, 2023

Where does it fail then?

It fails on the first use of ant, here: https://github.com/apache/cassandra/blob/trunk/build.xml#L178-L180

If I do not add that check for 8, we will also build with JDK8 for trunk. What do I miss?

No, because you've removed it from the jenkins dsl groovy (in the first commit in this PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants