CASSANDRA-19964 second approach - CREATE TABLE LIKE for copying Basic Table definition using create table parser #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, can i take up this issue? |
smiklosovic
changed the title
smiklosovic
changed the title
smiklosovic
changed the title
smiklosovic
reviewed
Dec 3, 2024
| @@ -208,6 +208,11 @@ public ColumnMetadata(String ksName, | |||
| this.mask = mask; | |||
| } | |||
|
|
|||
| protected ColumnMetadata cloneWithoutTableName(String keyspace, String table) | |||
| { | |||
| return new ColumnMetadata(keyspace, table, name, type, position, kind, mask); | |||
There was a problem hiding this comment.
this is not a good idea, we are not copying it "deep enough".
There was a problem hiding this comment.
yes, you are right.
feel free to left your review comments |
smiklosovic
reviewed
Dec 5, 2024
| } | ||
|
|
||
| @Override | ||
| public void validate(ClientState state) | ||
| { | ||
| super.validate(state); | ||
|
|
||
| if (isCreateLike) |
There was a problem hiding this comment.
this should be all added to your new PR?
There was a problem hiding this comment.
copytablestatement only deal with create table like CQL, so we may do not need this .
for cql like create table if not exist ta like tb, there will be a SyntaxException. I have a test for this in CreateLikeCqlParseTest
Maxwell-Guo
force-pushed
the
CASSANDRA-19964-like-parse
branch
from
f301539 to
a5448b0
Compare
Maxwell-Guo
force-pushed
the
CASSANDRA-19964-like-parse
branch
from
a5448b0 to
e4d8031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for CASSANDRA-19664:
1、we can copy table under the same keyspace of under different keysapces.
2、only support basic table schema : primary key(partition key and clustering key), regular columns , static columns, column masking, table params(compaction, compression and so on).