Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology rebuild on bounce #3739

Draft
wants to merge 10 commits into
base: cep-15-accord
Choose a base branch
from
Draft

Topology rebuild on bounce #3739

wants to merge 10 commits into from

Conversation

ifesdjeen
Copy link
Contributor

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@ifesdjeen
Implement field saving/loading in AccordJournal
7b31886
@ifesdjeen
Implement field saving/loading in AccordJournal
98de52c
@ifesdjeen
Migrate in memory journal to CommandChange logic shared with AccordJo…
1ab6e7f 
…urnal

Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20115
@ifesdjeen
Integrate
643a5c7
@ifesdjeen
Minor improvements
b149b54
@ifesdjeen
Allow saving commands on replay
7fd644e
@ifesdjeen
Fix AccordJournalCompactionTest
7af90d4
@ifesdjeen
Persist durable before during replay, too
8fdcbe2
@ifesdjeen
Fix topology replay during bootstrap and startup, decouple Accord fro…
a1e2c61 
…m TCM

Includes multiple changes, primary ones:
  * Removed nodes now live in TCM, no need to discover historic epochs in order to find removed nodes
  * CommandStore <-> RangesForEpochs mappings required for startup are now stored in journal, and CS can be set up _without_ topology replay
  * Topology replay is fully done via journal (where we store topologies themselves), and topology metadata table (where we store redundant/closed information)
  * Fixed various bugs related to propagation and staleness
     * TCM was previously relied on for "fetching" epoch: we can not rely on it as there's no guarantee we will see a consecutive epoch when grabbing Metadata#current
     * Redundant / closed during replay was set with incorrect ranges in 1 of the code paths
     * TCM was contacted multiple times for historical epochs, which made startup much longer under some circumstances
@ifesdjeen ifesdjeen force-pushed the topology-rebuild-on-bounce branch from 89d9d67 to a1e2c61 Compare December 16, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ifesdjeen