CASSANDRA-20104 sorting of nodetool status output - further refactorings and improvements #3744
+1,802
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiklosovic
commented
Dec 15, 2024
| // More tokens than nodes (aka vnodes)? | ||
| if (dcs.size() < tokensToEndpoints.size()) | ||
| if (hostIDMap.size() < nodesOfTokens) |
There was a problem hiding this comment.
I strongly believe this is a bug. The code as it was does not make any sense.
| "Default ordering is ascending for 'ip', 'host', 'id', 'token', 'rack' and descending for 'load', 'owns', 'state'. " + | ||
| "Sorting by token is possible only when cluster does not use vnodes. When using vnodes, default " + | ||
| "sorting is by id otherwise by token.", | ||
| allowedValues = {"ip", "host", "load", "owns", "id", "rack", "state", "none"}) |
There was a problem hiding this comment.
If we are also including token do we not have to include token in the allowed values?
patch by Manish Pillai; reviwed by Stefan Miklosovic, Bernardo Botella for CASSANDRA-20104 Co-authored-by: Stefan Miklosovic <[email protected]>
smiklosovic
force-pushed
the
CASSANDRA-20104
branch
from
3f835e1 to
4507859
Compare
smiklosovic
commented
Dec 16, 2024
| @Override | ||
| public void execute(NodeProbe probe) | ||
| { | ||
| PrintStream out = probe.output().out; | ||
| PrintStream errOut = probe.output().err; |
There was a problem hiding this comment.
We were wrongly sending errors to out instead of err output across this class. This is now fixed.
smiklosovic
force-pushed
the
CASSANDRA-20104
branch
from
4507859 to
474dc72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira