[CASSANDRA-20167][trunk] Reduce memory allocations in miscellaneous places along write path #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 28, 2025 18:09
Avoid objects allocations used only in rarely invoked logic branches. Memorize things which can be computed once. Avoid unnecessary iterators for the write hot path. Do not recreate immutable objects with the same content. Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever for CASSANDRA-20167
- parse header and query options flags as int, without EnumSet overheads - avoid ByteBuffer slicing in 2 places - avoid a capturing lambda allocation by using an explicit interface Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever for CASSANDRA-20167
- avoid an unnecessary byte buffer slicing (DataOutputBuffer.toByteArray()) during a Mutation serialization - replace AtomicLong viewLockAcquireStart field in Mutation with volatile long and AtomicLongFieldUpdater usage Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever for CASSANDRA-20167
…earchIterator within inclusionTester() logic which checks if we need to iterate over particular column for each cell. It is not really needed here: we've just added these cells during PartitionUpdate creation Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever for CASSANDRA-20167
…Parameters Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever for CASSANDRA-20167
…te within a single table ( very typical case when we just modify a single row) Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever for CASSANDRA-20167
…fications constructor, we had to copy columnSpecs for every request because in one place plain List is used and ImmutableList in another one Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever for CASSANDRA-20167
vlsi
reviewed
Jan 30, 2025
…ater is used Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever, Vladimir Sitnikov for CASSANDRA-20167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary allocations in different places along write path
Patch by Dmitry Konstantinov; reviewed by Chris Lohfink, Michael Semb Wever for CASSANDRA-20167