Skip to content

Commit

Permalink
[CELEBORN-767][DOC] Update the docs of `celeborn.client.spark.push.so…
Browse files Browse the repository at this point in the history
…rt.memory.threshold`

### What changes were proposed in this pull request?

As title

### Why are the changes needed?

To clarify the usage of conf `celeborn.client.spark.push.sort.memory.threshold`

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Pass GA

Closes #1680 from cfmcgrady/docs.

Authored-by: Fu Chen <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
  • Loading branch information
cfmcgrady authored and waitinfuture committed Jul 5, 2023
1 parent a0f4be6 commit 3af5c23
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3270,15 +3270,6 @@ object CelebornConf extends Logging {
.longConf
.createWithDefault(500000)

val CLIENT_PUSH_SORT_MEMORY_THRESHOLD: ConfigEntry[Long] =
buildConf("celeborn.client.spark.push.sort.memory.threshold")
.withAlternative("celeborn.push.sortMemory.threshold")
.categories("client")
.doc("When SortBasedPusher use memory over the threshold, will trigger push data.")
.version("0.3.0")
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("64m")

val CLIENT_PUSH_SORT_PIPELINE_ENABLED: ConfigEntry[Boolean] =
buildConf("celeborn.client.spark.push.sort.pipeline.enabled")
.withAlternative("celeborn.push.sort.pipeline.enabled")
Expand All @@ -3289,6 +3280,18 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(false)

val CLIENT_PUSH_SORT_MEMORY_THRESHOLD: ConfigEntry[Long] =
buildConf("celeborn.client.spark.push.sort.memory.threshold")
.withAlternative("celeborn.push.sortMemory.threshold")
.categories("client")
.doc("When SortBasedPusher use memory over the threshold, will trigger push data. If the" +
s" pipeline push feature is enabled (`${CLIENT_PUSH_SORT_PIPELINE_ENABLED.key}=true`)," +
" the SortBasedPusher will trigger a data push when the memory usage exceeds half of the" +
" threshold(by default, 32m).")
.version("0.3.0")
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("64m")

val TEST_ALTERNATIVE: OptionalConfigEntry[String] =
buildConf("celeborn.test.alternative.key")
.withAlternative("celeborn.test.alternative.deprecatedKey")
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration/client.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ license: |
| celeborn.client.shuffle.partitionSplit.mode | SOFT | soft: the shuffle file size might be larger than split threshold. hard: the shuffle file size will be limited to split threshold. | 0.3.0 |
| celeborn.client.shuffle.partitionSplit.threshold | 1G | Shuffle file size threshold, if file size exceeds this, trigger split. | 0.3.0 |
| celeborn.client.shuffle.rangeReadFilter.enabled | false | If a spark application have skewed partition, this value can set to true to improve performance. | 0.2.0 |
| celeborn.client.spark.push.sort.memory.threshold | 64m | When SortBasedPusher use memory over the threshold, will trigger push data. | 0.3.0 |
| celeborn.client.spark.push.sort.memory.threshold | 64m | When SortBasedPusher use memory over the threshold, will trigger push data. If the pipeline push feature is enabled (`celeborn.client.spark.push.sort.pipeline.enabled=true`), the SortBasedPusher will trigger a data push when the memory usage exceeds half of the threshold(by default, 32m). | 0.3.0 |
| celeborn.client.spark.push.sort.pipeline.enabled | false | Whether to enable pipelining for sort based shuffle writer. If true, double buffering will be used to pipeline push | 0.3.0 |
| celeborn.client.spark.push.unsafeRow.fastWrite.enabled | true | This is Celeborn's optimization on UnsafeRow for Spark and it's true by default. If you have changed UnsafeRow's memory layout set this to false. | 0.2.2 |
| celeborn.client.spark.shuffle.forceFallback.enabled | false | Whether force fallback shuffle to Spark's default. | 0.3.0 |
Expand Down

0 comments on commit 3af5c23

Please sign in to comment.