-
Notifications
You must be signed in to change notification settings - Fork 355
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CELEBORN-768] Change default config values for batch rpcs and netty …
…memory allocator ### What changes were proposed in this pull request? Changes the following configs' default values | config | previous value | current value | | ------------- | ------------- | ------------- | | celeborn.network.memory.allocator.share | false | true | | celeborn.client.shuffle.batchHandleChangePartition.enabled | false | true | | celeborn.client.shuffle.batchHandleCommitPartition.enabled | false | true | ### Why are the changes needed? In my test, when graceful shutdown is enabled but ```celeborn.client.shuffle.batchHandleChangePartition.enabled``` and ```celeborn.client.shuffle.batchHandleCommitPartition.enabled``` disabled, the worker takes much longer to stop than the two configs enabled. In another test where worker size is quite small(2 cores 4 G) and replication is on, if shared allocator is disabled, the netty's onTrim fails to release memory, and further causes push data timeout. ### Does this PR introduce _any_ user-facing change? No, these conifgs are introduces from 0.3.0. ### How was this patch tested? Passes GA. Closes #1682 from waitinfuture/768. Authored-by: zky.zhoukeyong <[email protected]> Signed-off-by: zky.zhoukeyong <[email protected]>
- Loading branch information
1 parent
95f0830
commit 4300835
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters