Skip to content

Commit

Permalink
[CELEBORN-1652] Throw TransportableError for failure of sending PbRea…
Browse files Browse the repository at this point in the history
…dAddCredit to avoid flink task get stuck

### What changes were proposed in this pull request?

Throw `TransportableError` for failure of sending `PbReadAddCredit` to avoid flink task get stuck.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

by manual verification

Closes #2811 from codenohup/fix-send-credit.

Authored-by: codenohup <[email protected]>
Signed-off-by: Shuang <[email protected]>
(cherry picked from commit af930e7)
Signed-off-by: Shuang <[email protected]>
  • Loading branch information
codenohup authored and RexXiong committed Oct 15, 2024
1 parent 5e552af commit 9012b7f
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,12 @@ public void onSuccess(ByteBuffer response) {

@Override
public void onFailure(Throwable e) {
logger.warn(
"Send PbReadAddCredit to {} failed, detail {}",
logger.error(
"Send PbReadAddCredit to {} failed, streamId {}, detail {}",
NettyUtils.getRemoteAddress(client.getChannel()),
streamId,
e.getCause());
messageConsumer.accept(new TransportableError(streamId, e));
}
});
}
Expand Down

0 comments on commit 9012b7f

Please sign in to comment.