Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CELEBORN-844] Fix incorrect config name in ConfigEntity checkvalue method and format message #1765

Closed
wants to merge 1 commit into from
Closed

[CELEBORN-844] Fix incorrect config name in ConfigEntity checkvalue method and format message #1765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@ object CelebornConf extends Logging {
.version("0.2.0")
.doc("Port for master to bind.")
.intConf
.checkValue(p => p >= 1024 && p < 65535, "invalid port")
.checkValue(p => p >= 1024 && p < 65535, "Invalid port")
.createWithDefault(9097)

val HA_ENABLED: ConfigEntry[Boolean] =
Expand Down Expand Up @@ -1596,7 +1596,7 @@ object CelebornConf extends Logging {
.doc("Port to bind of master node <id> in HA mode.")
.version("0.3.0")
.intConf
.checkValue(p => p >= 1024 && p < 65535, "invalid port")
.checkValue(p => p >= 1024 && p < 65535, "Invalid port")
.createWithDefault(9097)

val HA_MASTER_NODE_RATIS_HOST: OptionalConfigEntry[String] =
Expand All @@ -1617,7 +1617,7 @@ object CelebornConf extends Logging {
.doc("Ratis port to bind of master node <id> in HA mode.")
.version("0.3.0")
.intConf
.checkValue(p => p >= 1024 && p < 65535, "invalid port")
.checkValue(p => p >= 1024 && p < 65535, "Invalid port")
.createWithDefault(9872)

val HA_MASTER_RATIS_RPC_TYPE: ConfigEntry[String] =
Expand Down Expand Up @@ -2381,7 +2381,7 @@ object CelebornConf extends Logging {
"sorter memory, partition sorter will stop sorting.")
.version("0.2.0")
.doubleConf
.checkValue(v => v >= 0.0 && v <= 1.0, "should be in [0.0, 1.0].")
.checkValue(v => v >= 0.0 && v <= 1.0, "Should be in [0.0, 1.0].")
.createWithDefault(0.1)

val WORKER_DIRECT_MEMORY_RATIO_FOR_READ_BUFFER: ConfigEntry[Double] =
Expand Down Expand Up @@ -2800,7 +2800,7 @@ object CelebornConf extends Logging {
.version("0.3.0")
.doc(s"Timeout for a task to push data rpc message. This value should better be more than twice of `${PUSH_TIMEOUT_CHECK_INTERVAL.key}`")
.timeConf(TimeUnit.MILLISECONDS)
.checkValue(_ > 0, "celeborn.client.push.data.timeout must be positive!")
.checkValue(_ > 0, "Value must be positive!")
.createWithDefaultString("120s")

val TEST_CLIENT_PUSH_PRIMARY_DATA_TIMEOUT: ConfigEntry[Boolean] =
Expand Down Expand Up @@ -3196,7 +3196,7 @@ object CelebornConf extends Logging {
.doc("Max retry times for requestCommitFiles RPC.")
.version("0.3.0")
.intConf
.checkValue(v => v > 0, "value must be positive")
.checkValue(v => v > 0, "Value must be positive")
.createWithDefault(4)

val CLIENT_COMMIT_IGNORE_EXCLUDED_WORKERS: ConfigEntry[Boolean] =
Expand Down Expand Up @@ -3404,7 +3404,7 @@ object CelebornConf extends Logging {
.doc("It controls if Celeborn collect timer metrics for some operations. Its value should be in [0.0, 1.0].")
.version("0.2.0")
.doubleConf
.checkValue(v => v >= 0.0 && v <= 1.0, "should be in [0.0, 1.0].")
.checkValue(v => v >= 0.0 && v <= 1.0, "Should be in [0.0, 1.0].")
.createWithDefault(1.0)

val METRICS_SLIDING_WINDOW_SIZE: ConfigEntry[Int] =
Expand Down Expand Up @@ -3447,7 +3447,7 @@ object CelebornConf extends Logging {
.doc("Master's Prometheus port.")
.version("0.3.0")
.intConf
.checkValue(p => p >= 1024 && p < 65535, "invalid port")
.checkValue(p => p >= 1024 && p < 65535, "Invalid port")
.createWithDefault(9098)

val WORKER_PROMETHEUS_HOST: ConfigEntry[String] =
Expand All @@ -3466,7 +3466,7 @@ object CelebornConf extends Logging {
.doc("Worker's Prometheus port.")
.version("0.3.0")
.intConf
.checkValue(p => p >= 1024 && p < 65535, "invalid port")
.checkValue(p => p >= 1024 && p < 65535, "Invalid port")
.createWithDefault(9096)

val METRICS_EXTRA_LABELS: ConfigEntry[Seq[String]] =
Expand Down Expand Up @@ -3577,7 +3577,7 @@ object CelebornConf extends Logging {
.version("0.3.0")
.doc("Vector batch size for columnar shuffle.")
.intConf
.checkValue(v => v > 0, "value must be positive")
.checkValue(v => v > 0, "Value must be positive")
.createWithDefault(10000)

val COLUMNAR_SHUFFLE_OFF_HEAP_ENABLED: ConfigEntry[Boolean] =
Expand Down
Loading