[CELEBORN-845][BUG] Sort memory counter won't decrease after sort failed #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...er/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1766 +/- ##
==========================================
- Coverage 46.74% 46.74% -0.00%
==========================================
Files 162 162
Lines 10026 10027 +1
Branches 925 926 +1
==========================================
Hits 4686 4686
Misses 5021 5021
- Partials 319 320 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
FMX
changed the title
FMX
added a commit
that referenced
this pull request
Jul 27, 2023
### What changes were proposed in this pull request? Decrease sort memory counter after sorting procedure is complete. ### Why are the changes needed? Fix incorrect sort memory counter. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? UT. Closes #1766 from FMX/CELEBORN-845. Authored-by: mingji <[email protected]> Signed-off-by: mingji <[email protected]> (cherry picked from commit 90959cb) Signed-off-by: mingji <[email protected]>
zwangsheng
pushed a commit
to zwangsheng/RemoteShuffleService
that referenced
this pull request
Aug 28, 2023
### What changes were proposed in this pull request? Decrease sort memory counter after sorting procedure is complete. ### Why are the changes needed? Fix incorrect sort memory counter. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? UT. Closes apache#1766 from FMX/CELEBORN-845. Authored-by: mingji <[email protected]> Signed-off-by: mingji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Decrease sort memory counter after sorting procedure is complete.
Why are the changes needed?
Fix incorrect sort memory counter.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
UT.