[CELEBORN-850][INFRA] Add SBT CI #1771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1771 +/- ##
==========================================
+ Coverage 46.78% 46.96% +0.18%
==========================================
Files 162 162
Lines 10012 10012
Branches 923 923
==========================================
+ Hits 4683 4701 +18
+ Misses 5019 5005 -14
+ Partials 310 306 -4 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
add flink 1.15/1.17 support add flink-it/flink-client-shaded support rebase branch pure-sbt align final jar name with maven add prefix and update project name enabled ci bump junit jdk 17 try set java.io.tmpdir Revert "try" This reverts commit 9e78f0d. try try disable parallelExecution try upload log try try try debug info print debug info try fix remove celeborn-client/test fail-fast: false test by group fix
pan3793
reviewed
Aug 1, 2023
| @@ -553,7 +573,7 @@ trait SparkClientProjects { | |||
| ) ++ commonUnitTestDependencies | |||
| ) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
should it be covered by spotless?
There was a problem hiding this comment.
after experimentation, it seems that the maven spotless plugin is unable to format source files located outside the source directory.
pan3793
reviewed
Aug 1, 2023
| push: | ||
| branches: | ||
| - main | ||
| - branch-* |
There was a problem hiding this comment.
Emm ... I'm afraid we should exclude branch-0.3 and lower
There was a problem hiding this comment.
Since we don't backport this to branch-0.3, I think it's safe.
pan3793
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds new GitHub Actions workflows to enable Continuous Integration using SBT based on #1764
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA