Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-857][TEST] Refine DataPushQueueSuiteJ #1774

Closed
wants to merge 4 commits into from

Conversation

cfmcgrady
Copy link
Contributor

What changes were proposed in this pull request?

  1. This PR propose renaming the class DataPushQueueSuitJ to DataPushQueueSuiteJ in order to enable its integration with the test suite. This change is required to comply with our maven-surefire-plugin plugin rule

https://github.com/apache/incubator-celeborn/blob/5f0295e9f3f1f5781af124ae319e202a2594a103/pom.xml#L543-L551

  1. To fix a potential logic bug in the test, tasks within DataPushQueue may inadvertently be consumed by the DataPushers built-in thread DataPusher-${taskId}, leading to test suite failures.

截屏2023-07-31 下午12 08 06

截屏2023-07-31 下午12 07 49

Why are the changes needed?

fix DataPushQueueSuiteJ bug

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GA

@cfmcgrady
Copy link
Contributor Author

cc @pan3793 @waitinfuture @zy-jordan

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1774 (5f3ee17) into main (5f0295e) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 5f3ee17 differs from pull request most recent head 9862e98. Consider uploading reports for the commit 9862e98 to get more accurate results

@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
- Coverage   46.81%   46.80%   -0.00%     
==========================================
  Files         162      162              
  Lines       10012    10012              
  Branches      923      923              
==========================================
- Hits         4686     4685       -1     
+ Misses       5019     5018       -1     
- Partials      307      309       +2     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cfmcgrady
Copy link
Contributor Author

the suite ran as expected now.

[INFO] Running org.apache.celeborn.client.write.DataPushQueueSuiteJ
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.278 s - in org.apache.celeborn.client.write.DataPushQueueSuiteJ

Copy link
Contributor

@waitinfuture waitinfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Merging to main.

@cfmcgrady cfmcgrady deleted the refine-data-push-queue-suite branch July 31, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants