Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-726][FOLLOWUP] Amend method names #1776

Closed
wants to merge 1 commit into from

Conversation

waitinfuture
Copy link
Contributor

What changes were proposed in this pull request?

As title

Why are the changes needed?

As title

Does this PR introduce any user-facing change?

No

How was this patch tested?

Passes GA

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1776 (3cc0e1e) into main (f869ab2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1776   +/-   ##
=======================================
  Coverage   46.94%   46.94%           
=======================================
  Files         162      162           
  Lines       10012    10012           
  Branches      923      923           
=======================================
  Hits         4699     4699           
  Misses       5006     5006           
  Partials      307      307           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cfmcgrady cfmcgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AngersZhuuuu AngersZhuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waitinfuture
Copy link
Contributor Author

Thanks, merging to main.

waitinfuture added a commit that referenced this pull request Aug 7, 2023
### What changes were proposed in this pull request?
As title

### Why are the changes needed?
As title

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Passes GA

Closes #1776 from waitinfuture/method.

Authored-by: zky.zhoukeyong <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
zwangsheng pushed a commit to zwangsheng/RemoteShuffleService that referenced this pull request Aug 28, 2023
### What changes were proposed in this pull request?
As title

### Why are the changes needed?
As title

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Passes GA

Closes apache#1776 from waitinfuture/method.

Authored-by: zky.zhoukeyong <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants