Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-867][BUILD] Add maven local repository to sbt respositories #1780

Closed
wants to merge 1 commit into from

Conversation

cfmcgrady
Copy link
Contributor

@cfmcgrady cfmcgrady commented Aug 1, 2023

What changes were proposed in this pull request?

As title

Why are the changes needed?

#1764 (comment)

before this PR

> ./build/sbt -Pspark-3.3 "clean; show celeborn-common/csrResolvers"
[info] * FileRepository(local, Patterns(ivyPatterns=Vector(/Users/fchen/.ivy2/local/[organisation]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)([branch]/)[revision]/[type]s/[artifact](-[classifier]).[ext]), artifactPatterns=Vector(/Users/fchen/.ivy2/local/[organisation]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)([branch]/)[revision]/[type]s/[artifact](-[classifier]).[ext]), isMavenCompatible=false, descriptorOptional=false, skipConsistencyCheck=false), FileConfiguration(true, None))
[info] * private: file:/dev/null
[info] * aliyun-maven: https://maven.aliyun.com/nexus/content/groups/public/
[info] * huawei-central: https://mirrors.huaweicloud.com/repository/maven/
[success] Total time: 0 s, completed 2023-8-1 11:40:25
> ./build/sbt -Pspark-3.3 "clean; show celeborn-client-spark-3/managedClasspath" | grep spark
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-core_2.12/3.3.2/spark-core_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-sql_2.12/3.3.2/spark-sql_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-launcher_2.12/3.3.2/spark-launcher_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-kvstore_2.12/3.3.2/spark-kvstore_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-network-common_2.12/3.3.2/spark-network-common_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-network-shuffle_2.12/3.3.2/spark-network-shuffle_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-unsafe_2.12/3.3.2/spark-unsafe_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-tags_2.12/3.3.2/spark-tags_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/spark-project/spark/unused/1.0.0/unused-1.0.0.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-sketch_2.12/3.3.2/spark-sketch_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/Library/Caches/Coursier/v1/https/mirrors.huaweicloud.com/repository/maven/org/apache/spark/spark-catalyst_2.12/3.3.2/spark-catalyst_2.12-3.3.2.jar)

after this PR

> ./build/sbt -Pspark-3.3 "clean; show celeborn-common/csrResolvers"
[success] Total time: 0 s, completed 2023-8-1 11:45:02
[info] * FileRepository(local, Patterns(ivyPatterns=Vector(/Users/fchen/.ivy2/local/[organisation]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)([branch]/)[revision]/[type]s/[artifact](-[classifier]).[ext]), artifactPatterns=Vector(/Users/fchen/.ivy2/local/[organisation]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)([branch]/)[revision]/[type]s/[artifact](-[classifier]).[ext]), isMavenCompatible=false, descriptorOptional=false, skipConsistencyCheck=false), FileConfiguration(true, None))
[info] * mavenLocal: file:/Users/fchen/.m2/repository/
[info] * private: file:/dev/null
[info] * aliyun-maven: https://maven.aliyun.com/nexus/content/groups/public/
[info] * huawei-central: https://mirrors.huaweicloud.com/repository/maven/
[success] Total time: 0 s, completed 2023-8-1 11:45:02
> ./build/sbt -Pspark-3.3 "clean; show celeborn-client-spark-3/managedClasspath" | grep spark
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-core_2.12/3.3.2/spark-core_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-sql_2.12/3.3.2/spark-sql_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-launcher_2.12/3.3.2/spark-launcher_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-kvstore_2.12/3.3.2/spark-kvstore_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-network-common_2.12/3.3.2/spark-network-common_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-network-shuffle_2.12/3.3.2/spark-network-shuffle_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-unsafe_2.12/3.3.2/spark-unsafe_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-tags_2.12/3.3.2/spark-tags_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/spark-project/spark/unused/1.0.0/unused-1.0.0.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-sketch_2.12/3.3.2/spark-sketch_2.12-3.3.2.jar)
[info] * Attributed(/Users/fchen/.m2/repository/org/apache/spark/spark-catalyst_2.12/3.3.2/spark-catalyst_2.12-3.3.2.jar)

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GA

@cfmcgrady
Copy link
Contributor Author

cc @zhongqiangczq @pan3793

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1780 (2516051) into main (f869ab2) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1780   +/-   ##
=======================================
  Coverage   46.94%   46.94%           
=======================================
  Files         162      162           
  Lines       10012    10012           
  Branches      923      923           
=======================================
  Hits         4699     4699           
  Misses       5006     5006           
  Partials      307      307           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793 pan3793 closed this in f2fc520 Aug 1, 2023
@pan3793
Copy link
Member

pan3793 commented Aug 1, 2023

Thanks, merged to main

@cfmcgrady cfmcgrady deleted the sbt-maven-local branch August 1, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants