[CELEBORN-846][FOLLOWUP] Fix broken link caused by unknown RPC. #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1794 +/- ##
==========================================
- Coverage 46.60% 46.49% -0.11%
==========================================
Files 162 162
Lines 10079 10103 +24
Branches 928 929 +1
==========================================
Hits 4696 4696
- Misses 5073 5097 +24
Partials 310 310
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
FMX
changed the title
FMX
force-pushed
the
CELEBORN-846-FOLLOWUP
branch
from
736a751
to
bf69e85
Compare
FMX
force-pushed
the
CELEBORN-846-FOLLOWUP
branch
from
bf69e85
to
753629c
Compare
pan3793
reviewed
Aug 8, 2023
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Aug 8, 2023
cfmcgrady
approved these changes
Aug 9, 2023
…age/ControlMessages.scala Co-authored-by: Cheng Pan <[email protected]>
Co-authored-by: Cheng Pan <[email protected]>
waitinfuture
approved these changes
Aug 11, 2023
waitinfuture
pushed a commit
that referenced
this pull request
Aug 11, 2023
### What changes were proposed in this pull request? Keep ReleaseSlots RPC to make sure that 0.3 client can worker with 0.3.1-SNAPSHOT and 0.4.0-SNAPSHOT. This PR will need to merged into main and branch-0.3. ### Why are the changes needed? Ditto. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? GA and cluster. Closes #1794 from FMX/CELEBORN-846-FOLLOWUP. Lead-authored-by: mingji <[email protected]> Co-authored-by: Ethan Feng <[email protected]> Signed-off-by: zky.zhoukeyong <[email protected]> (cherry picked from commit 7d0e257) Signed-off-by: zky.zhoukeyong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Keep ReleaseSlots RPC to make sure that 0.3 client can worker with 0.3.1-SNAPSHOT and 0.4.0-SNAPSHOT.
This PR will need to merged into main and branch-0.3.
Why are the changes needed?
Ditto.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
GA and cluster.