[CELEBORN-877][DOC] Document on SBT #1795
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
+ Coverage 46.60% 46.75% +0.16%
==========================================
Files 162 162
Lines 10079 10078 -1
Branches 928 927 -1
==========================================
+ Hits 4696 4711 +15
+ Misses 5073 5059 -14
+ Partials 310 308 -2 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
cc @pan3793 @waitinfuture PTAL when you have time |
docs/developers/sbt.md
Outdated
| To create a Celeborn distribution like those distributed by the [Celeborn Downloads](https://celeborn.apache.org/download/) page, and that is laid out so as to be runnable, use `./build/make-distribution.sh` in the project root directory. | ||
|
|
||
| ``` | ||
| ./build/make-distribution.sh --sbt |
There was a problem hiding this comment.
no, it's a placeholder now, I intend to file a separate PR to support this feature.
There was a problem hiding this comment.
but there is a --mvn </path/mvn>
There was a problem hiding this comment.
maybe --sbt-enabled?
|
Good job! The article is clear and detailed. |
|
cc @RexXiong @zhongqiangczq @FMX, I suppose it's friendly enough for new developers to learn the SBT. |
Co-authored-by: Cheng Pan <[email protected]>
Co-authored-by: Cheng Pan <[email protected]>
Co-authored-by: Cheng Pan <[email protected]>
docs/developers/sbt.md
Outdated
| ``` | ||
| For more about how to run individual tests with sbt, see the [sbt documentation](https://www.scala-sbt.org/1.x/docs/Testing.html) and [JUnit Interface](https://github.com/sbt/junit-interface/#junit-interface). | ||
|
|
||
| # Accelerating SBT |
There was a problem hiding this comment.
too generic, it's network specific
There was a problem hiding this comment.
Do you have any suggestions?
There was a problem hiding this comment.
after thought, I think it's fine, we can put other content in the future, like how to skip unnecessary checks, run tests in parallel，etc.
Co-authored-by: Cheng Pan <[email protected]>
|
Thanks, merged to main |
What changes were proposed in this pull request?
As title
Why are the changes needed?
As title
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual test