Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-909][DOC] Mention celeborn.worker.directMemoryRatioToResume default value changed in main/0.4 #1836

Closed
wants to merge 2 commits into from

Conversation

zwangsheng
Copy link
Contributor

@zwangsheng zwangsheng commented Aug 24, 2023

What changes were proposed in this pull request?

As title

Why are the changes needed?

After #1829 we set celeborn.worker.directMemoryRatioToResume default value from 0.5 to 0.7.

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

No

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1836 (9ac9883) into main (1550f92) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 9ac9883 differs from pull request most recent head df014a5. Consider uploading reports for the commit df014a5 to get more accurate results

@@            Coverage Diff             @@
##             main    #1836      +/-   ##
==========================================
- Coverage   46.45%   46.43%   -0.01%     
==========================================
  Files         163      163              
  Lines       10135    10135              
  Branches      934      934              
==========================================
- Hits         4707     4705       -2     
- Misses       5117     5118       +1     
- Partials      311      312       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@waitinfuture waitinfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!


- Since 0.4.0, Celeborn won't be compatible with Celeborn client that versions below 0.3.0.
Note that: It's strongly recommended to use the same version of Client and Celeborn Master/Worker in production.

- Since 0.4.0, Celeborn won't support `org.apache.spark.shuffle.celeborn.RssShuffleManager`.

## Upgrading from 0.2 to 0.3
## Upgrading from 0.3.0 to 0.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed version to 0.3.1

zhouyifan279 pushed a commit to zhouyifan279/incubator-celeborn that referenced this pull request Aug 28, 2023
…e` default value changed in main/0.4

### What changes were proposed in this pull request?
As title

### Why are the changes needed?
After apache#1829 we set `celeborn.worker.directMemoryRatioToResume` default value from `0.5` to `0.7`.

### Does this PR introduce _any_ user-facing change?
Yes

### How was this patch tested?
No

Closes apache#1836 from zwangsheng/CELEBORN-909.

Lead-authored-by: zwangsheng <[email protected]>
Co-authored-by: Keyong Zhou <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants