[CELEBORN-912] Support build with Spark 3.5 #1850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1850 +/- ##
=======================================
Coverage 46.70% 46.70%
=======================================
Files 163 163
Lines 10153 10153
Branches 934 934
=======================================
Hits 4741 4741
Misses 5103 5103
Partials 309 309 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhouyifan279
force-pushed
the
build-spark-3.5
branch
from
4116508
to
da90430
Compare
cfmcgrady
reviewed
Aug 28, 2023
pom.xml
Outdated
Comment on lines
1010
to
1011
| <jackson.version>2.15.2</jackson.version> | ||
| <jackson.databind.version>2.15.2</jackson.databind.version> |
There was a problem hiding this comment.
Suggested change
| <jackson.version>2.15.2</jackson.version> | |
| <jackson.databind.version>2.15.2</jackson.databind.version> |
pan3793
approved these changes
Aug 29, 2023
|
Thanks, merging to main |
kerwin-zk
pushed a commit
that referenced
this pull request
Sep 5, 2024
### What changes were proposed in this pull request? Introduce `spark-3.5-columnar-shuffle` module to support columnar shuffle for Spark 3.5. ### Why are the changes needed? #1850 does not support columnar shuffle for Spark 3.5, in which version building `spark-3-columnar-shuffle` module has compilation error. The compilation error is caused by apache/spark#40784, which incompatible changes move `InternalType` from `AtomicType` to `PhysicalDataType`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #2710 from SteNicholas/CELEBORN-912. Authored-by: SteNicholas <[email protected]> Signed-off-by: xiyu.zk <[email protected]>
s0nskar
pushed a commit
to s0nskar/celeborn
that referenced
this pull request
Sep 16, 2024
### What changes were proposed in this pull request? Introduce `spark-3.5-columnar-shuffle` module to support columnar shuffle for Spark 3.5. ### Why are the changes needed? apache#1850 does not support columnar shuffle for Spark 3.5, in which version building `spark-3-columnar-shuffle` module has compilation error. The compilation error is caused by apache/spark#40784, which incompatible changes move `InternalType` from `AtomicType` to `PhysicalDataType`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes apache#2710 from SteNicholas/CELEBORN-912. Authored-by: SteNicholas <[email protected]> Signed-off-by: xiyu.zk <[email protected]>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? Introduce `spark-3.5-columnar-shuffle` module to support columnar shuffle for Spark 3.5. ### Why are the changes needed? apache#1850 does not support columnar shuffle for Spark 3.5, in which version building `spark-3-columnar-shuffle` module has compilation error. The compilation error is caused by apache/spark#40784, which incompatible changes move `InternalType` from `AtomicType` to `PhysicalDataType`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes apache#2710 from SteNicholas/CELEBORN-912. Authored-by: SteNicholas <[email protected]> Signed-off-by: xiyu.zk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support build with Spark 3.5
Why are the changes needed?
Keep up with upstream.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Build with
mvnandsbtlocally.