Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-929][INFRA] Add dependencies check CI #1852

Closed
wants to merge 28 commits into from

Conversation

cfmcgrady
Copy link
Contributor

What changes were proposed in this pull request?

As title

Why are the changes needed?

As title

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GA

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1852 (6c21d57) into main (7e373fe) will increase coverage by 0.06%.
Report is 9 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
+ Coverage   46.46%   46.52%   +0.06%     
==========================================
  Files         163      164       +1     
  Lines       10164    10184      +20     
  Branches      936      936              
==========================================
+ Hits         4722     4737      +15     
- Misses       5130     5134       +4     
- Partials      312      313       +1     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cfmcgrady cfmcgrady marked this pull request as ready for review August 29, 2023 10:51
@cfmcgrady cfmcgrady changed the title [CELEBORN-XXX][INFRA] Add dependencies check CI [CELEBORN-929][INFRA] Add dependencies check CI Aug 29, 2023
@cfmcgrady cfmcgrady closed this Aug 29, 2023
@cfmcgrady cfmcgrady reopened this Aug 29, 2023
@cfmcgrady
Copy link
Contributor Author

GA passed, PTAL. cc @pan3793 @waitinfuture

Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @waitinfuture

Copy link
Contributor

@waitinfuture waitinfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

pull_request:
branches:
- main
- branch-*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the existing release branch does not has the scripts

Copy link
Contributor Author

@cfmcgrady cfmcgrady Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the script dev/dependencies.sh was introduced in version 0.4.0-SNAPSHOT, which is the current main branch, we don't backport this pull request to an existing release branch, such as branch-0.3. I think it's safe, WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not backport.

if we merge it as-is to main only, will PR target to branch-0.3 trigger the check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR target to branch-0.3 will not trigger this check, it's the same as SBT CI.

@cfmcgrady
Copy link
Contributor Author

thanks for the review. @SteNicholas @waitinfuture @pan3793

merging to main(v0.4.0).

@cfmcgrady cfmcgrady closed this in 142d12c Sep 7, 2023
@cfmcgrady cfmcgrady deleted the audit-deps-ci branch September 7, 2023 06:03
@cfmcgrady cfmcgrady self-assigned this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants