-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-977] Support RocksDB as recover DB backend #1913
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
- Coverage 46.61% 46.61% -0.00%
==========================================
Files 164 164
Lines 10247 10256 +9
Branches 937 937
==========================================
+ Hits 4776 4780 +4
- Misses 5158 5160 +2
- Partials 313 316 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cxzl25
changed the title
[CELEBORN-977] Support RocksDB as recover DB Backend
[CELEBORN-977] Support RocksDB as recover DB backend
Sep 14, 2023
LICENSE related stuff need to update |
jiaoqingbo
reviewed
Sep 15, 2023
pan3793
reviewed
Sep 18, 2023
pan3793
approved these changes
Sep 18, 2023
jiaoqingbo
approved these changes
Sep 18, 2023
cfmcgrady
reviewed
Sep 18, 2023
cfmcgrady
approved these changes
Sep 18, 2023
Merged to main |
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
LevelDB does not support mac arm version.
The released
leveldbjni-all
fororg.fusesource.leveldbjni
does not support AArch64 Linux, we need to useorg.openlabtesting.leveldbjni
.See https://issues.apache.org/jira/browse/HADOOP-16614
Does this PR introduce any user-facing change?
No.
How was this patch tested?
local test