-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1400] Bump Ratis version from 2.5.1 to 3.0.1 #2480
Conversation
4ac7ef8
to
b9e92b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. (Note that I am not familiar with CELEBORN.)
does it allow rolling upgrades? should we upgrade followers or the leader first or something else? |
@SteNicholas Hi, I wonder if this PR affects the rolling upgrade process. Can ratis 3.0.1 servers communicate with ratis 2.5.1 servers? |
@FMX, I didn't test the rolling upgrade process in cluster. I would like to try rolling upgrade for validation of above question. |
We meet same issue as https://issues.apache.org/jira/browse/RATIS-1860, better to upgrade ratis |
@FMX, @pan3793, @AngersZhuuuu, I have tested the rolling upgrade process in test environment as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SteNicholas, LGTM overall. I am just wondering what the write buffer size we should set, and what is the reason?
b9e92b9
to
79cf2dc
Compare
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java
Outdated
Show resolved
Hide resolved
79cf2dc
to
edc610c
Compare
edc610c
to
39523e4
Compare
39523e4
to
5df6bdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Merge to main(v0.5.0) |
What changes were proposed in this pull request?
Bump Ratis version from 2.5.1 to 3.0.1. Address incompatible changes:
Why are the changes needed?
Bump Ratis version from 2.5.1 to 3.0.1. Ratis has released v3.0.0, v3.0.1, which release note refers to 3.0.0, 3.0.1. The 3.0.x version include new features like pluggable metrics and lease read, etc, some improvements and bugfixes including:
3.0.0: Change list of ratis 3.0.0 In total, there are roughly 100 commits diffing from 2.5.1 including:
3.0.1:This is a bugfix release. See the changes between 3.0.0 and 3.0.1 releases.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Cluster manual test.