[CELEBORN-1452][0.4] Master follower node metadata is out of sync after installing snapshot #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stalling snapshot ### What changes were proposed in this pull request? Fix Master follower node metadata is out of sync after installing snapshot ### Why are the changes needed? Follower node metadata is out of sync, when a master-slave switchover occurs, there are major risks to the stability of the cluster. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. Closes apache#2547 from leixm/issue_1452. Authored-by: Xianming Lei <[email protected]> Signed-off-by: SteNicholas <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-0.4 #2563 +/- ##
==============================================
+ Coverage 47.08% 47.14% +0.07%
==============================================
Files 185 185
Lines 11936 11965 +29
Branches 1055 1060 +5
==============================================
+ Hits 5619 5640 +21
- Misses 5943 5947 +4
- Partials 374 378 +4 ☔ View full report in Codecov by Sentry. |
RexXiong
approved these changes
Jun 13, 2024
RexXiong
pushed a commit
that referenced
this pull request
Jun 13, 2024
…er installing snapshot ### What changes were proposed in this pull request? backport #2547 to `branch-0.4` Fix Master follower node metadata is out of sync after installing snapshot ### Why are the changes needed? Follower node metadata is out of sync, when a master-slave switchover occurs, there are major risks to the stability of the cluster. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. Closes #2563 from cfmcgrady/CELEBORN-1452-branch-0.4. Lead-authored-by: Xianming Lei <[email protected]> Co-authored-by: Fu Chen <[email protected]> Signed-off-by: Shuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
backport #2547 to
branch-0.4Fix Master follower node metadata is out of sync after installing snapshot
Why are the changes needed?
Follower node metadata is out of sync, when a master-slave switchover occurs, there are major risks to the stability of the cluster.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.