Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1532][HELM] Make helm charts more customizable #2654

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

ChenYi015
Copy link
Contributor

What changes were proposed in this pull request?

  • Add image.registry and rename imagePullSecrets to image.pullSecrets
  • Rename masterReplicas/workerReplicas to master.replicas/worker.replicas
  • Add master.labels/worker.labels
  • Rename podAnnotations to master.annotations/worker.annotations
  • Rename nodeSelector to master.nodeSelector/worker.nodeSelector
  • Rename affinity.master/affinity.worker to master.affinity/worker.affinity
  • Rename tolerations to master.tolerations/worker.tolerations
  • Rename environments to master.env/worker.env
  • Add master.envFrom/worker.envFrom
  • Rename priorityClass.master/priorityClass.worker to master.priorityClass/worker.priorityClass
  • Rename resources.master/resources.worker to master.resources/worker.resources
  • Rename dnsPolicy to master.dnsPolicy/worker.dnsPolicy
  • Rename hostNetwork to master.hostNetwork/worker.hostNetwork
  • Rename service to master.service/worker.service
  • Rename podMonitor to master.podMonitor/worker.podMonitor
  • Rename securityContext to master.podSecurityContext/worker.podSecurityContext
  • Add master.securityContext/worker.securityContext

Why are the changes needed?

  • Make the Celeborn Helm charts more customizable and improve the maintenance.
  • Unified the various configurations, all master/worker related configurations are prefixed with master/worker.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Locally test.

…tyClass and worker.priorityClass

Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Aug 21, 2024
@RexXiong RexXiong removed the stale label Aug 29, 2024
Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Sep 19, 2024
@FMX
Copy link
Contributor

FMX commented Sep 24, 2024

@ChenYi015 Can you split this PR into several small PRs? Changing one feature in one PR can be easier for reviewers.

@github-actions github-actions bot removed the stale label Sep 24, 2024
Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants